use Locale.ROOT for case-insensitive keyword normalisation - #2437
Merged
manticore-projects merged 1 commit intoJul 30, 2026
Merged
Conversation
Signed-off-by: dxbjavid <dxbjavid@gmail.com>
Contributor
|
Looks good but I need to fix the build script first :-( |
Contributor
Author
|
no rush at all. happy to rebase onto master once the build script is sorted, just give me a shout if you need anything changed on my side. |
Contributor
Author
|
Thank you for the merge. Appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
several parser helpers fold SQL keywords and identifiers to upper case with the no-argument toUpperCase(), which uses the JVM default locale. under a Turkish or Azeri locale a keyword containing the letter i (union, intersect, minus, time, timestamp, like and friends) folds to a dotted İ instead of ASCII I, so the following Enum.valueOf lookup throws IllegalArgumentException and a valid statement fails to parse, while deparsing emits the wrong casing. switching the conversions to Locale.ROOT keeps case folding of SQL text independent of the runtime locale.